Skip empty checksum values in compact index metadata#9713
Merged
Conversation
Some registries such as GitHub Package Registry serve /info files with empty checksum entries like "2.0.1 |checksum:", which parse into an empty array and crashed resolution with a NoMethodError on nil. Treat an empty or missing checksum value the same as an absent checksum key, while keeping the "Invalid checksum" error for non-empty invalid values. Fixes #9677 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The spec added in #9687 serialized the cached gemspec with the in-process RubyGems, but `#to_ruby` output differs across RubyGems versions, so it failed on the system RubyGems jobs where the file was written by an older version. Serialize in a subprocess like the sibling spec does. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compact index
/infofiles served by some registries such as GitHub Package Registry can contain empty checksum entries like2.0.1 |checksum:. The parser turns that into["checksum", []]andEndpointSpecification#parse_metadatapassed the resultingnildigest toChecksum.from_api, crashing resolution with aNoMethodErrorwrapped in aGemspecError. An empty or missing checksum value is now treated the same as an absent checksum key, so resolution continues with the checksum left unset. Non-empty invalid values still raise the existingInvalid checksum for ...error.Fixes #9677